This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web:canvaskit] migrate Paint API to UniqueRef #41230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
yjbanov
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 17, 2023
…124987) flutter/engine@30e1c43...b2d0738 2023-04-17 [email protected] Adds AndroidSurfaceGLImpeller unit tests (flutter/engine#40979) 2023-04-17 [email protected] [web:canvaskit] migrate Paint API to UniqueRef (flutter/engine#41230) 2023-04-17 [email protected] Migrate uses of deprecated SkImage->encodeToData (flutter/engine#41204) 2023-04-17 [email protected] Roll Skia from 962800967591 to d9e216e62223 (1 revision) (flutter/engine#41270) 2023-04-17 [email protected] Roll Fuchsia Mac SDK from xPacy_rLieLS05d_g... to K1LGtKXyxRlW3Q9O1... (flutter/engine#41271) 2023-04-17 [email protected] Roll Skia from 82665485077b to 962800967591 (1 revision) (flutter/engine#41267) 2023-04-17 [email protected] Roll Skia from 5c4d2a518736 to 82665485077b (2 revisions) (flutter/engine#41266) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from xPacy_rLieLS to K1LGtKXyxRlW If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
yjbanov
added a commit
that referenced
this pull request
Apr 18, 2023
This should go after #41230. Removes the remaining usages of `skia_object_cache.dart` and deletes it. Also fixes flutter/flutter#86632
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Paint API to
UniqueRef. This includesPaint,ImageFilter(and all subtypes),ColorFilter(and all subtypes).Also fix the following memory leaks:
CkPaintis frequently used by layers where a one-off paint object is created, used, and immediately dropped.CkPaintnow has adisposemethod, and all one-off usages now dispose of the paint after they are done.CkColorFilter.initRawImageFilterwas leaking theSkColorFiltercreated by_initRawColorFilterinside the expression.CkManagedSkImageFilterConvertible.imageFilternow takes a closure, which allows the implementation decide on the lifetime of theSkImageFiltervended to the caller. BecauseCkColorFilteris a const class it cannot store C++ instances inside its own fields, so it creates a temporarySkImageFilterclass to be used by the caller and then it needs to delete it. Now it does.