This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Migrate android AOT to engine_v2. #41229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The artifacts have been used in prod for a few weeks already and this change is just migrating the generation of the artifacts to engine_v2 builds and moving the legacy recipe to staging.
Contributor
Author
|
@zanderso can we land this one while we figure out the best way to remove the double zip of FlutterMacOS.framework.zip? flutter/flutter#124911 |
zanderso
approved these changes
Apr 18, 2023
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
lgtm, but can we wait to land infra changes until the tree recovers from flutter/flutter#125037 ?
Contributor
Author
Thanks, seems like the tree has stabilized. Adding the autosubmit label. |
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2023
…125069) flutter/engine@6d263ea...5fcc7b7 2023-04-18 [email protected] [Impeller] Gpu model information to Skia gold (flutter/engine#41216) 2023-04-18 [email protected] [Impeller] faster glyph atlas generation by removing data copies (flutter/engine#41290) 2023-04-18 [email protected] Migrate android AOT to engine_v2. (flutter/engine#41229) 2023-04-18 [email protected] Roll Skia from 5bd4bdc0d8e2 to f80ee1088861 (8 revisions) (flutter/engine#41302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The artifacts have been used in prod for a few weeks already and this change is just migrating the generation of the artifacts to engine_v2 builds and moving the legacy recipe to staging.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.