This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Fix arm64 floating-point test failure #41228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlutterMutatorViewTest.TransformedFrameIsCorrect and FlutterMutatorViewTest.RoundRectClipsToPath both apply transforms then do exact comparisons on the resulting 4x4 matrices of CGFloat values. There are very small differences between the elements in the resulting matrices, on the order of 1e-15, depending on the CPU architecture on which the floating point operations were run. Similar to elsewhere in the framework and engine, we now perform floating point equality tests within some small error bound -- I've arbitrarily selected 1e-10. Issue: flutter/flutter#124840
loic-sharma
approved these changes
Apr 14, 2023
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
LGTM but consider getting approval from someone else familiar with these tests
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 15, 2023
…124907) flutter/engine@4552a6e...c8d84cf 2023-04-15 [email protected] [macOS] Fix arm64 floating-point test failure (flutter/engine#41228) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
LGTM |
exaby73
pushed a commit
to exaby73/flutter_nevercode
that referenced
this pull request
Apr 17, 2023
…lutter#124907) flutter/engine@4552a6e...c8d84cf 2023-04-15 [email protected] [macOS] Fix arm64 floating-point test failure (flutter/engine#41228) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlutterMutatorViewTest.TransformedFrameIsCorrect and FlutterMutatorViewTest.RoundRectClipsToPath both apply transforms then do exact comparisons on the resulting 4x4 matrices of CGFloat values.
There are very small differences between the elements in the resulting matrices, on the order of 1e-15, depending on the CPU architecture on which the floating point operations were run.
Similar to elsewhere in the framework and engine, we now perform floating point equality tests within some small error bound -- I've arbitrarily selected 1e-10.
Issue: flutter/flutter#124840
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.