This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove jazzy and Xcode properties from impeller-cmake-example builder #41222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Apr 14, 2023
| cpu: arm64 | ||
| config_name: mac_impeller_cmake_example | ||
| $flutter/osx_sdk : >- | ||
| { "sdk_version": "14a5294e" } |
Member
There was a problem hiding this comment.
It uses the macOS SDK: https://github.com/flutter/engine/blob/main/ci/builders/mac_impeller_cmake_example.json#L17. Will that still be there? You can try this change in presubmit by temporarily commenting out bringup: true.
Member
Author
There was a problem hiding this comment.
Hm, the builders inherit dimensions from their orchestrator? That's unexpected...
It doesn't seem to be inheriting the dependencies. https://ci.chromium.org/p/flutter/builders/staging/Mac%20Staging%20Engine%20Drone/87661
This is the first time I've played with the v2 stuff.
Trying with bringup to see what happens.
Member
There was a problem hiding this comment.
I'm not sure. I say let's try this change in presubmit, and if it works, let's ship it.
Member
Author
There was a problem hiding this comment.
zanderso
approved these changes
Apr 15, 2023
jmagman
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 41222, due to - The status or check suite Mac Host clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 15, 2023
…124914) flutter/engine@f6e64a8...f24e37b 2023-04-15 [email protected] Roll Fuchsia Linux SDK from Z0of2S9pf3Zn1nsJP... to Y_tD90hDX_jiubGbC... (flutter/engine#41238) 2023-04-15 [email protected] Remove jazzy and Xcode properties from impeller-cmake-example builder (flutter/engine#41222) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Z0of2S9pf3Zn to Y_tD90hDX_ji If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to exaby73/flutter_nevercode
that referenced
this pull request
Apr 17, 2023
…lutter#124914) flutter/engine@f6e64a8...f24e37b 2023-04-15 [email protected] Roll Fuchsia Linux SDK from Z0of2S9pf3Zn1nsJP... to Y_tD90hDX_jiubGbC... (flutter/engine#41238) 2023-04-15 [email protected] Remove jazzy and Xcode properties from impeller-cmake-example builder (flutter/engine#41222) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Z0of2S9pf3Zn to Y_tD90hDX_ji If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builder doesn't use or install jazzy or Xcode, remove the properties from the config.
Passing without these properties: https://ci.chromium.org/p/flutter/builders/try/Mac%20impeller-cmake-example/14