[Impeller] Gpu model information to Skia gold #41216
Conversation
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Code lgtm. I don't know how this will manifest in skia gold, but sounds like it should work.
| '--work-dir', _tempPath, | ||
| '--test-name', cleanTestName(testName), | ||
| '--png-file', goldenFile.path, | ||
| '--add-test-key', 'gpu_string:$gpuString', |
There was a problem hiding this comment.
This is enough to make skia gold segregate the golden results?
There was a problem hiding this comment.
Is this the same as adding to the list of keys provided as initialization for the test? Those are collected in _getKeys
There was a problem hiding this comment.
Good point, @Piinks. This should be added to dimensions, which later gets used in _getKeys().
There was a problem hiding this comment.
Is this the same as adding to the list of keys provided as initialization for the test? Those are collected in _getKeys
Done
| '--work-dir', _tempPath, | ||
| '--test-name', cleanTestName(testName), | ||
| '--png-file', goldenFile.path, | ||
| '--add-test-key', 'gpu_string:$gpuString', |
There was a problem hiding this comment.
Good point, @Piinks. This should be added to dimensions, which later gets used in _getKeys().
|
In local testing the gpu_string is I'm going to rebase to clear up the validation problem. |
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
The dimensions change looks good to me!
gaaclarke
added
the
autosubmit
…125069) flutter/engine@6d263ea...5fcc7b7 2023-04-18 [email protected] [Impeller] Gpu model information to Skia gold (flutter/engine#41216) 2023-04-18 [email protected] [Impeller] faster glyph atlas generation by removing data copies (flutter/engine#41290) 2023-04-18 [email protected] Migrate android AOT to engine_v2. (flutter/engine#41229) 2023-04-18 [email protected] Roll Skia from 5bd4bdc0d8e2 to f80ee1088861 (8 revisions) (flutter/engine#41302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
4 participants
Does two things:
impeller::ContextThis should help reduce noise/flakiness in golden images.