Remove package:js references and move to dart:js_interop #41212
Conversation
|
This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick. |
flutter-dashboard
bot
added
the
platform-web
|
@eyebrowsoffire PTAL, thanks! |
|
Do we still need the dependencies in |
|
test-exempt: preparing for dependency roll |
I haven't focused on removing Edit: It looks like I can't use dart:js_util directly in some files (I come across static errors), so we can't remove package:js just yet. |
srujzs
force-pushed
the
master
branch
7 times, most recently
from
3162409 to
b5d8f16
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
srujzs
force-pushed
the
master
branch
3 times, most recently
from
e91f380 to
94e55e5
Compare
dart:js_interop and package:js will start conflicting. Eventually, we want people to only use dart:js_interop, so this CL refactors code to stop using js.dart. Once we migrate code to JS types, we can remove references to package:js altogether and not have to use js_util.dart.
…125510) flutter/engine@0e23698...469e5b4 2023-04-25 [email protected] Remove package:js references and move to dart:js_interop (flutter/engine#41212) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
5 participants
dart:js_interop and package:js will start conflicting. Eventually, we want people to only use dart:js_interop, so this CL refactors code to do that.
Unblocks https://dart-review.googlesource.com/c/sdk/+/294130/8 and prevents confusing shadowing of dart:js_interop annotations like we do today.
Pre-launch Checklist
///).