[Impeller] Make //impeller/display_list TU naming consistent. #41174
Conversation
flar
left a comment
flar
left a comment
There was a problem hiding this comment.
My comments are "food for thought" at this point.
| namespace impeller { | ||
|
|
||
| class DisplayListDispatcher final : public flutter::DlOpReceiver { | ||
| class DLDispatcher final : public flutter::DlOpReceiver { |
There was a problem hiding this comment.
DisplayList uses Dl as a prefix with a lower case L.
Also, perhaps DlImpellerDispatcher to match DlSkCanvasDispatcher?
There was a problem hiding this comment.
Another thought is that these naming changes seem to be creating consistency with code that is in the DL module. Should they have their own naming convention as they are the Impeller implementations of some of the DL interfaces rather than actual APIs/classes provided by DL?
Whoops. Fixed and made it consistent.
I think being consistent with DL is fine as thats the interface this module is trying to adhere to. |
|
@flar PTAL? |
chinmaygarde
added
e: impeller
autosubmit
|
auto label is removed for flutter/engine, pr: 41174, due to - The status or check suite Windows Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 41174, due to - The status or check suite Mac Host clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
No change in functionality. I've just renamed the TU's to replace `display_list_` to `dl_`. I am sure there are chances to make the naming better. For instance, the op receiver still being named a dispatcher.
chinmaygarde
added
the
autosubmit
…125152) flutter/engine@d626f16...0a53cf6 2023-04-19 [email protected] [Impeller] Make //impeller/display_list TU naming consistent. (flutter/engine#41174) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
No change in functionality. I've just renamed the TU's to replace
display_list_todl_. I am sure there are chances to make the naming better. For instance, the op receiver still being named a dispatcher.