Do not use Macmini7,1 for host tests #41159
Conversation
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
I wish we could add comments to .json files to put a link to the issue explaining why the restriction is there!
dnfield
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 41159, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Seems the change is not picked up by the pre-submit build. https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/160302/overview still uses the old |
That one is allowed to run on the old ones - I only updated the dimensions for the drones that run |
dnfield
added
the
autosubmit
I took this back. The change takes effect right away. Here is the task where the dimension is enforced: https://chromium-swarm.appspot.com/task?id=619400c517759a10&o=true&w=true |
This target also runs impeller_unittests that aren't safe to run right now on Macmini7,1 I missed this in #41159
fixes flutter/flutter#124678 those machines do not support compute subgroups. They make up only a relatively small fraction of the pool. This does not restrict the arm machines, as they're already restricted by the cpu architecture dimension.
This target also runs impeller_unittests that aren't safe to run right now on Macmini7,1 I missed this in flutter#41159
3 participants
fixes flutter/flutter#124678
those machines do not support compute subgroups. They make up only a relatively small fraction of the pool.
This does not restrict the arm machines, as they're already restricted by the cpu architecture dimension.