This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Delete obsolete tests #41142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Apr 13, 2023
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 13, 2023
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
[Impeller] Delete obsolete tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important coverage these tests were helping with now lives in the other subgroup tests, which target actual in-tree shaders rather than test fixture shaders.
The test fixture shaders have at least a couple bugs left in them that sometimes show up on Intel macs, and I'm not interested in further debugging or fixing them like I did for path_polyline.comp.
Part of flutter/flutter#124678, but does not fix the flake mentioned in that bug (instead deletes tests that are susceptible to a different flake I found while trying to reproduce that one).