Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 12, 2023

Fixes flutter/flutter#122534

Adds a descritiption for building the host_debug_unopt_arm64 and ios_sim_unopt_arm64 to the mac arm64 bots.

Does not run host tests yet, but will be easy to do that after flutter/flutter#103386 is resolved.

@cbracken fyi

@dnfield dnfield changed the title arm64 builds for mac/ios? Add builders for arm64 on macOS unopt Apr 13, 2023
@dnfield dnfield marked this pull request as ready for review April 13, 2023 04:32
"type": "gcs",
"include_paths": [
],
"name": "host_debug_unopt_arm64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the only purpose of this build to validate it builds correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, until we can run tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have said:

We're not ready to run host unit tests on CI for reasons in flutter/flutter#103386. It seems close.

This is running tests on iOS simulator though.

"os=Mac-12",
"cpu=arm64"
],
"gclient_custom_vars": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gclient_variables?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copy-pasted from the other ones.

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @keyonghan this will add more arm builders that potentially could be xcode-cache corrupted if we try to update just the arm bots to test out your named cache work. However we can turn these off temporarily if that's a problem, if needed.

LGTM once @godofredoc is happy.

@godofredoc
Copy link
Contributor

Adding my +2 with nits because I'll be ooo the rest of the day.

Copy link
Contributor

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 13, 2023
@auto-submit auto-submit bot merged commit eb3e7d5 into flutter:main Apr 13, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2023
@dnfield dnfield deleted the arm64 branch April 14, 2023 03:32
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Apr 14, 2023
Add builders for arm64 on macOS unopt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Engine CI iOS simulator tests fail on arm64 bots

3 participants