It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #41135 at sha 0ab6407

@kevmoo Could I request a hot fix rollout for this? This is affecting our production app.

@chillbrodev – which version of Flutter are you using?

@chillbrodev – which version of Flutter are you using?

Currently using 3.7.12

Let me ask around. CC @yjbanov

@kevmoo Do we know if this was rolled into 3.10?

@chillbrodev – I think so.

Sounds great, Im rolling back my fix to test it out. Thanks for the rapid verify

Finally got around to testing this out and had noticed it wasn't deployed in 3.10 and if anything was somewhat worse. Looks like the information in flutter/flutter#128349 discusses the fix. Looking forward to seeing this hit stable.

@chillbrodev – able to verify against master?

@chillbrodev – able to verify against master?

I can cut a build, standby. In the meantime, we switched the web renderer to canvaskit and that seems to have solved it.

@chillbrodev – canvaskit is where we'd like most folks to go in the future. Is load time okay?

@kevmoo We're going to have our QA team hammer it tonight, so I will have better info tomorrow. Though from my brief tests, the load seems good on WIFI. I'll have to go try it out on cellular during lunch.

Secondly, I tried to build against master but having issues with build runner. So probs will ditch this effort right now as I have other bugs to squash. Here is the build_runner output...

Failed to build build_runner:build_runner:
../../../../../.pub-cache/hosted/pub.dev/watcher-1.0.2/lib/src/constructable_file_system_event.dart:7:57: Error: The class 'FileSystemEvent' can't be extended, implemented, or mixed in outside of its library because it's a sealed class.
abstract class _ConstructableFileSystemEvent implements FileSystemEvent {
                                                        ^
Failed to build build_runner:build_runner:
../../../.pub-cache/hosted/pub.dev/watcher-1.0.2/lib/src/constructable_file_system_event.dart:7:57: Error: The class 'FileSystemEvent' can't be extended, implemented, or mixed in outside of its library because it's a sealed class.
abstract class _ConstructableFileSystemEvent implements FileSystemEvent {