This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP][Impeller] Improve accuracy of glyph spacing (#41101) #41123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I believe the correct branch is |
Contributor
|
Correct, the beta is based on 3.10-candidate.1. If you're aiming for a Google CP, please file a bug with more context. |
zanderso
changed the base branch from
flutter-3.10-candidate.3
to
flutter-3.10-candidate.1
flutter-dashboard
bot
added
embedder
Member
|
Ooooh. I tried just changing the target branch, but I think the branch for the pull request has to be rebased on candidate.1 as well. |
(cherry picked from commit aa74ecc)
bdero
force-pushed
the
bdero/text-rounding-3.10-cp
branch
from
24e7e12 to
98b925a
Compare
Member
Author
|
Alrighty, fixed this up to point to candidate.1 |
Member
|
@CaseyHillers do you know why the |
Member
Author
|
Looks like this is good to go |
zanderso
approved these changes
Apr 13, 2023
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
lgtm
release team will handle merging.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP for #41101