This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Metal: Read from onscreen textures #41107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
bdero
force-pushed
the
bdero/metal-read-from-framebuffer
branch
from
6b253b6 to
a0b3919
Compare
bdero
force-pushed
the
bdero/metal-read-from-framebuffer
branch
from
a0b3919 to
82db011
Compare
chinmaygarde
approved these changes
Apr 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2023
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
Removes the "final blit" for Metal because flutter#41085 allows us to read from the onscreen texture. We can't do this trick when running the Vulkan backend right now because it doesn't have `SupportsReadFromResolve` yet, which means we need to toggle between two textures.
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Jul 14, 2023
…on Vulkan. The background is in the commit message for flutter#41107. I idly flipped it without thinking of the resolve aspect. The behavior is the same but the code IMO is now easier to follow.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the "final blit" for Metal because #41085 allows us to read from the onscreen texture.
We can't do this trick when running the Vulkan backend right now because it doesn't have
SupportsReadFromResolveyet, which means we need to toggle between two textures.