This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Add docs on how to debug global generators. #41102
Merged
auto-submit
merged 2 commits into
flutter:main
from
godofredoc:add_global_generator_debug
Apr 12, 2023
Merged
Add docs on how to debug global generators. #41102
auto-submit
merged 2 commits into
flutter:main
from
godofredoc:add_global_generator_debug
Apr 12, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global generators require sub-build dependencies to validate them. This PR adds some basic documentation to help debugging. Bug: flutter/flutter#124572
zanderso
reviewed
Apr 12, 2023
| These are the commands to execute for our example build: | ||
|
|
||
| ``` | ||
| pushd <gclient checkout>/src/out |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can any of this be scripted? We can put scripts in the ci/ directory of the flutter/engine repo.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible but may require some research. Opened flutter/flutter#124685 to track the CLI potential features.
zanderso
approved these changes
Apr 12, 2023
Contributor
|
auto label is removed for flutter/engine, pr: 41102, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2023
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
Add docs on how to debug global generators.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global generators require sub-build dependencies to validate them. This PR adds some basic documentation to help debugging.
Bug: flutter/flutter#124572
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.