Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

Global generators require sub-build dependencies to validate them. This PR adds some basic documentation to help debugging.

Bug: flutter/flutter#124572

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Global generators require sub-build dependencies to validate them. This
PR adds some basic documentation to help debugging.

Bug: flutter/flutter#124572
@godofredoc godofredoc requested a review from zanderso April 12, 2023 15:04
These are the commands to execute for our example build:

```
pushd <gclient checkout>/src/out
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can any of this be scripted? We can put scripts in the ci/ directory of the flutter/engine repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible but may require some research. Opened flutter/flutter#124685 to track the CLI potential features.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 12, 2023

auto label is removed for flutter/engine, pr: 41102, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@auto-submit auto-submit bot merged commit f5a895c into flutter:main Apr 12, 2023
@godofredoc godofredoc deleted the add_global_generator_debug branch April 12, 2023 17:28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 12, 2023
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Apr 14, 2023
Add docs on how to debug global generators.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants