[Impeller] add a generic porter duff blend foreground shader. #41098

jonahwilliams · 2023-04-12T00:43:50Z

The pipeline blend component of flutter/flutter#124025 . This should also land alongside flutter/flutter#124640 which was necessary before we had completely optimized the image filters for texture inputs.

Fixes flutter/flutter#121650
Fixes flutter/flutter#124025

impeller/entity/contents/content_context.h

flutter-dashboard · 2023-04-14T16:55:47Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

… blender_filter

bdero · 2023-04-14T22:22:58Z

impeller/entity/shaders/blending/porter_duff_blend.frag

+    frag_color = IPBlendPlus(frag_info.color, dst_color);
+  } else {
+    frag_color = IPBlendModulate(frag_info.color, dst_color);
+  }


Rather than enumerating these on the GPU, most of these can be parameterized with 4 coefficients:

frag_color = src * (frag_info.src_coeff + dst.a * frag_info.src_coeff_dst_alpha) + dst * (frag_info.dst_coeff + src.a * frag_info.dst_coeff_src_alpha);

And then the coefficients can be pulled from a LUT on the CPU without enumeration or hashing:

{src_coeff, src_coeff_dst_alpha, dst_coeff, dst_coeff_src_alpha} {0, 0, 0, 0}, // Clear {1, 0, 0, 0}, // Source {0, 0, 1, 0}, // Destination {1, 0, 1, -1}, // SourceOver {1, -1, 1, 0}, // DestinationOver {0, 1, 0, 0}, // SourceIn {0, 0, 0, 1}, // DestinationIn {1, -1, 0, 0}, // SourceOut {0, 0, 1, -1}, // DestinationOut {0, 1, 1, -1}, // SourceATop {1, -1, 0, 1}, // DestinationATop {1, -1, 1, -1}, // Xor {1, 0, 1, 0}, // Plus

I think we can also cover Modulate and Screen here by adding one more dst coefficient to multiply the source color in:

frag_color = src * (frag_info.src_coeff + dst.a * frag_info.src_coeff_dst_alpha) + dst * (frag_info.dst_coeff + src.a * frag_info.dst_coeff_src_alpha + src * frag_info.dst_coeff_src_color);

...and then the full table with all the blends becomes:

{src_coeff, src_coeff_dst_alpha, dst_coeff, dst_coeff_src_alpha, dst_coeff_src_color} {0, 0, 0, 0, 0}, // Clear {1, 0, 0, 0, 0}, // Source {0, 0, 1, 0, 0}, // Destination {1, 0, 1, -1, 0}, // SourceOver {1, -1, 1, 0, 0}, // DestinationOver {0, 1, 0, 0, 0}, // SourceIn {0, 0, 0, 1, 0}, // DestinationIn {1, -1, 0, 0, 0}, // SourceOut {0, 0, 1, -1, 0}, // DestinationOut {0, 1, 1, -1, 0}, // SourceATop {1, -1, 0, 1, 0}, // DestinationATop {1, -1, 1, -1, 0}, // Xor {1, 0, 1, 0, 0}, // Plus {0, 0, 0, 0, 1}, // Modulate {0, 0, 1, 0, -1}, // Screen

+cc @flar in case he has a moment to check my math :)

Seems like a more technically sound approach, I'll make this change.

Done, lines up with the current behavior using a 0.5 alpha red and blue:

ToT

Patched:

flutter-dashboard · 2023-04-14T23:12:10Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #41098 at sha 7cf5333

… blender_filter

bdero

LGTM!

… blender_filter

flutter-dashboard · 2023-04-15T17:21:02Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #41098 at sha 6a22ec3

jonahwilliams · 2023-04-15T18:45:27Z

Goldens revealed that the check to convert the foreground blend back into a snapshot wasn't quite working correctly so I took it out. now we only apply the foreground if we can absorb opacity (which should generally be always)

flutter-dashboard · 2023-04-15T19:32:59Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #41098 at sha ee32ab7

…r. (flutter/engine#41098)

…124933) flutter/engine@feb476b...da0805a 2023-04-15 [email protected] Roll Skia from 2a4d95762651 to 2d0b05335104 (1 revision) (flutter/engine#41250) 2023-04-15 [email protected] [Impeller] add a generic porter duff blend foreground shader. (flutter/engine#41098) 2023-04-15 [email protected] Roll Fuchsia Linux SDK from Y_tD90hDX_jiubGbC... to hacWN-gQSoWudziIS... (flutter/engine#41248) 2023-04-15 [email protected] Roll Fuchsia Mac SDK from RFyPoDrXzIiy-E3wn... to gI2knJ4Rh0yoK4Syd... (flutter/engine#41249) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Y_tD90hDX_ji to hacWN-gQSoWu fuchsia/sdk/core/mac-amd64 from RFyPoDrXzIiy to gI2knJ4Rh0yo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#124933) flutter/engine@feb476b...da0805a 2023-04-15 [email protected] Roll Skia from 2a4d95762651 to 2d0b05335104 (1 revision) (flutter/engine#41250) 2023-04-15 [email protected] [Impeller] add a generic porter duff blend foreground shader. (flutter/engine#41098) 2023-04-15 [email protected] Roll Fuchsia Linux SDK from Y_tD90hDX_jiubGbC... to hacWN-gQSoWudziIS... (flutter/engine#41248) 2023-04-15 [email protected] Roll Fuchsia Mac SDK from RFyPoDrXzIiy-E3wn... to gI2knJ4Rh0yoK4Syd... (flutter/engine#41249) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Y_tD90hDX_ji to hacWN-gQSoWu fuchsia/sdk/core/mac-amd64 from RFyPoDrXzIiy to gI2knJ4Rh0yo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

jonahwilliams added 6 commits April 7, 2023 15:27

[Impeller] blender filter investigation

3fc2b35

++

1ba540c

++

ed0d261

[Impeller] add an inline pipeline blend

66d6772

++

af07248

++

e8397ab

jonahwilliams commented Apr 12, 2023

View reviewed changes

impeller/entity/contents/content_context.h Outdated Show resolved Hide resolved

++

6ec2f59

jonahwilliams marked this pull request as ready for review April 12, 2023 00:47

jonahwilliams added 3 commits April 11, 2023 21:25

++

c2cc542

Merge branch 'master' of github.com:flutter/engine into blender_filter

07445d6

++

0c2793f

chinmaygarde assigned jonahwilliams Apr 13, 2023

chinmaygarde added the e: impeller label Apr 13, 2023

Jonah Williams added 2 commits April 14, 2023 09:52

Merge branch 'main' into blender_filter

a5228c1

++

0a7eb9f

jonahwilliams changed the title ~~[Impeller] add a generic pipeline blend foreground shader.~~ [Impeller] add a generic porterduff blend foreground shader. Apr 14, 2023

flutter-dashboard bot added the needs tests label Apr 14, 2023

jonahwilliams changed the title ~~[Impeller] add a generic porterduff blend foreground shader.~~ [Impeller] add a generic porter duff blend foreground shader. Apr 14, 2023

jonahwilliams added 3 commits April 14, 2023 09:56

Merge branch 'blender_filter' of github.com:jonahwilliams/engine into…

900a4ca

… blender_filter

licenses

a490fac

++

a6b6a9b

jonahwilliams requested review from bdero and chinmaygarde April 14, 2023 19:54

Merge branch 'main' into blender_filter

7cf5333

bdero reviewed Apr 14, 2023

View reviewed changes

bdero requested a review from flar April 14, 2023 22:23

flutter-dashboard bot added the will affect goldens label Apr 14, 2023

jonahwilliams added 2 commits April 14, 2023 17:58

++

7f12453

Merge branch 'blender_filter' of github.com:jonahwilliams/engine into…

dcc202d

… blender_filter

bdero approved these changes Apr 15, 2023

View reviewed changes

Jonah Williams added 3 commits April 14, 2023 20:20

Merge branch 'main' into blender_filter

1221a84

malioc diff

630a194

Merge branch 'blender_filter' of github.com:jonahwilliams/engine into…

6a22ec3

… blender_filter

require absorbing opacity

ee32ab7

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2023

auto-submit bot merged commit 6013a70 into flutter:main Apr 15, 2023

engine-flutter-autoroll mentioned this pull request Apr 15, 2023

Roll Flutter Engine from feb476b7b991 to 6013a707b67a (3 revisions) flutter/flutter#124932

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 15, 2023

6013a707b [Impeller] add a generic porter duff blend foreground shade…

c5e57c6

…r. (flutter/engine#41098)

engine-flutter-autoroll mentioned this pull request Apr 15, 2023

Roll Flutter Engine from feb476b7b991 to da0805a9cf03 (4 revisions) flutter/flutter#124933

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 15, 2023

6013a707b [Impeller] add a generic porter duff blend foreground shade…

f33507b

…r. (flutter/engine#41098)

bdero mentioned this pull request Apr 19, 2023

[Impeller] Fix transform regressions for chained filters #41332

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] add a generic porter duff blend foreground shader. #41098

[Impeller] add a generic porter duff blend foreground shader. #41098

Uh oh!

jonahwilliams commented Apr 12, 2023 •

edited

Loading

Uh oh!

Uh oh!

flutter-dashboard bot commented Apr 14, 2023

Uh oh!

bdero Apr 14, 2023

Uh oh!

jonahwilliams Apr 15, 2023

Uh oh!

jonahwilliams Apr 15, 2023

Uh oh!

flutter-dashboard bot commented Apr 14, 2023

Uh oh!

bdero left a comment

Uh oh!

flutter-dashboard bot commented Apr 15, 2023

Uh oh!

jonahwilliams commented Apr 15, 2023

Uh oh!

flutter-dashboard bot commented Apr 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Impeller] add a generic porter duff blend foreground shader. #41098

[Impeller] add a generic porter duff blend foreground shader. #41098

Uh oh!

Conversation

jonahwilliams commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard bot commented Apr 14, 2023

Uh oh!

bdero Apr 14, 2023

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Apr 15, 2023

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Apr 15, 2023

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Apr 14, 2023

Uh oh!

bdero left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Apr 15, 2023

Uh oh!

jonahwilliams commented Apr 15, 2023

Uh oh!

flutter-dashboard bot commented Apr 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jonahwilliams commented Apr 12, 2023 •

edited

Loading