Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

Mac_unopt is ready to replace Mac Unopt build. This change promotes the engine v2 build to use prod resources and moves the legacy Mac Unopt to staging.

Note: the failures in staging are related to lack of mac resources on staging to run successfully.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Mac_unopt is ready to replace Mac Unopt build. This change promotes
the engine v2 build to use prod resources and moves the legacy Mac Unopt
to staging.

Note: the failures in staging are related to lack of mac resources on
staging to run successfully.
@godofredoc godofredoc requested a review from zanderso April 11, 2023 16:38
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit auto-submit bot merged commit 96cb2f5 into flutter:main Apr 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2023
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Apr 14, 2023
@godofredoc godofredoc deleted the promote_unopt branch June 5, 2023 23:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants