Implement shadows in the skwasm renderer. #41056
Conversation
flutter-dashboard
bot
added
the
platform-web
| bool transparentOccluder, | ||
| ) { | ||
| // TODO(jacksongardner): implement this | ||
| final SkwasmPath path = uiPath as SkwasmPath; |
There was a problem hiding this comment.
pro tip: you can do uiPath as SkwasmPath; to promote the original uiPath variable to SkwasmPath. There's not need to rename the variable.
|
|
||
| namespace { | ||
| // These numbers have been chosen empirically to give a result closest to the | ||
| // material spec. |
There was a problem hiding this comment.
Do we need to keep these constants in sync with the mobile engine? If so, a link to the source of the mobile numbers could be useful.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
eyebrowsoffire
added
the
autosubmit
Implement shadows in the skwasm renderer.
3 participants
Add shadow rendering support to the skwasm renderer and write some unit tests.