Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cyanglaz
Copy link
Contributor

Only clean up platformView when shell is still alive during destruction.

Fixes flutter/flutter#123776

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit auto-submit bot merged commit 6641c74 into flutter:main Apr 11, 2023
@cyanglaz cyanglaz deleted the ios_background_crash branch April 11, 2023 03:48
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 11, 2023
cyanglaz pushed a commit to cyanglaz/engine that referenced this pull request Apr 13, 2023
…ter engine destroyed context (flutter#41037)

[ios] fix background crash when FlutterViewController is destroyed after engine destroyed context
@cyanglaz cyanglaz mentioned this pull request Apr 13, 2023
8 tasks
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Apr 14, 2023
…ter engine destroyed context (flutter#41037)

[ios] fix background crash when FlutterViewController is destroyed after engine destroyed context
CaseyHillers pushed a commit that referenced this pull request Apr 14, 2023
wujichao pushed a commit to wujichao/engine that referenced this pull request Oct 31, 2023
…ter engine destroyed context (flutter#41037)

[ios] fix background crash when FlutterViewController is destroyed after engine destroyed context
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in background: com.apple.main-thread - [FlutterEngine iosPlatformView]

2 participants