Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Makes iOS VoiceOver treat radio buttons as regualr buttons #41036

Merged
auto-submit merged 3 commits into from
Apr 12, 2023
Merged

Makes iOS VoiceOver treat radio buttons as regualr buttons #41036

auto-submit merged 3 commits into from
Apr 12, 2023

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Apr 10, 2023

fixes flutter/flutter#42793

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai requested review from gaaclarke and jmagman April 10, 2023 18:46
jmagman
jmagman approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 11, 2023

auto label is removed for flutter/engine, pr: 41036, due to - The status or check suite Linux Fuchsia FEMU has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@auto-submit auto-submit bot merged commit e7586d7 into flutter:main Apr 12, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2023
@engine-flutter-autoroll
e7586d71a Makes iOS VoiceOver treat radio buttons as regualr buttons (f…
7639abd 
…lutter/engine#41036)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2023
@engine-flutter-autoroll
e7586d71a Makes iOS VoiceOver treat radio buttons as regualr buttons (f…
244570f 
…lutter/engine#41036)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2023
@engine-flutter-autoroll
e7586d71a Makes iOS VoiceOver treat radio buttons as regualr buttons (f…
eecf3f2 
…lutter/engine#41036)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2023
@engine-flutter-autoroll
e7586d71a Makes iOS VoiceOver treat radio buttons as regualr buttons (f…
aa0260c 
…lutter/engine#41036)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2023
@engine-flutter-autoroll
e7586d71a Makes iOS VoiceOver treat radio buttons as regualr buttons (f…
ed130bb 
…lutter/engine#41036)
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Apr 14, 2023
@chunhtai @zhongwuzw
Makes iOS VoiceOver treat radio buttons as regualr buttons (flutter#4…
8c9894d 
…1036)

Makes iOS VoiceOver treat radio buttons as regualr buttons
@math1man math1man mentioned this pull request Apr 25, 2023
Closed
@chunhtai chunhtai mentioned this pull request Apr 25, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

1 more reviewer

@jmagman jmagman jmagman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Radiobutton not announced on iOS

2 participants

@chunhtai @jmagman