This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Account for pixel scale when checking against existing buffer storage size on iOS #4103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Sep 13, 2017
aam
added a commit
to aam/engine
that referenced
this pull request
Sep 21, 2017
… storage size (flutter#4103)" This reverts commit 2d530da as it looks like a potential cause of performance benchmark regressions on https://flutter-dashboard.appspot.com/benchmarks.html: - flutter_gallery_ios__transition_perf average_frame_build_time_millis - flutter_gallery_ios__transition_perf missed_frame_build_budget_count
aam
added a commit
that referenced
this pull request
Sep 21, 2017
… storage size (#4103)" (#4133) This reverts commit 2d530da as it looks like a potential cause of performance benchmark regressions on https://flutter-dashboard.appspot.com/benchmarks.html: - flutter_gallery_ios__transition_perf average_frame_build_time_millis - flutter_gallery_ios__transition_perf missed_frame_build_budget_count
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids extraneously re-allocating renderbuffers for new CALayers with the same size as the last one.
Fixes flutter/flutter#12061
Also indirectly fixes flutter/flutter#12022. Can't have GL - lifecycle races if we don't need to run these eagl stuff.
Tested with screen rotates, double-height status bar, posse app, various lifecycle transitions.