[Impeller] Fix issues in path polyline generation. #40975
Conversation
Bumps up some size assumptions to accomodate larger paths. Fixes bugs in the polyline shader that were highlighted by processing larger more complicated paths. Adds a test for a larger more complex path. Adds a playground for testing arbitrary SVG-encoded paths.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
My only suggestion, and this isn't an issue with the fix itself, is that perhaps the isolation of the conversion functions could be submitted as a separate PR so that the actual changes needed to fix this problem are easier to examine in isolation. (And I'll admit that I've been guilty of combining sweeping reorg changes with a bug fix myself.) |
dnfield
added
the
autosubmit
[Impeller] Fix issues in path polyline generation.
[Impeller] Fix issues in path polyline generation.
4 participants
Bumps up some size assumptions to accomodate larger paths.
Fixes bugs in the polyline shader that were highlighted by
processing larger more complicated paths.
Adds a test for a larger more complex path. Adds a playground for
testing arbitrary SVG-encoded paths.
Also re-organizes some Skia-to-Impeller utilities into their own TU instead of as scattered static methods in various TUs (@flar @gaaclarke fyi)
Next steps for strokes:
However, with this patch I think I have enough to do some more interesting experiments around stroke rendering for real.