This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] adjusted the rotated text test to have an opaque background and account for screen scale #40954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and account for screen scale
bdero
reviewed
Apr 5, 2023
| paint.color = Color(0.1, 0.1, 0.1, 1.0); | ||
| canvas.DrawRect( | ||
| Rect::MakeLTRB(0, 0, GetWindowSize().width, GetWindowSize().height), | ||
| paint); |
Member
There was a problem hiding this comment.
nit: DrawPaint would also work here.
Member
Author
There was a problem hiding this comment.
Good call. I guess we should probably add docstrings. It didn't occur to me that's what it would do, but makes sense.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 6, 2023
… background and account for screen scale (flutter/engine#40954)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 6, 2023
… background and account for screen scale (flutter/engine#40954)
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 6, 2023
…ions) (#124300) Manual roll requested by [email protected] flutter/engine@610cdf0...1ec74c6 2023-04-06 [email protected] Revert "[web] Move text editing nodes outside of shadowDOM - reopened" (flutter/engine#40960) 2023-04-05 [email protected] [web] Move text editing nodes outside of shadowDOM - reopened (flutter/engine#40904) 2023-04-05 [email protected] [Impeller] adjusted the rotated text test to have an opaque background and account for screen scale (flutter/engine#40954) 2023-04-05 [email protected] Copy canvaskit files directly into `flutter_web_sdk` (flutter/engine#40951) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
I'm seeing this flake still. I think we need to have something in gold that accounts for the GPU model. |
Member
Author
Is this flaking or getting confused since it is so different than the old goldens? It seems like there should be a way to reset the test but I couldn't find a way. |
Member
Author
Member
Author
|
I've added an ignore rule for that test: https://flutter-engine-gold.skia.org/ignores I think this will allow us to observe all the variations and decide what to do. |
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…ions) (flutter#124300) Manual roll requested by [email protected] flutter/engine@610cdf0...1ec74c6 2023-04-06 [email protected] Revert "[web] Move text editing nodes outside of shadowDOM - reopened" (flutter/engine#40960) 2023-04-05 [email protected] [web] Move text editing nodes outside of shadowDOM - reopened (flutter/engine#40904) 2023-04-05 [email protected] [Impeller] adjusted the rotated text test to have an opaque background and account for screen scale (flutter/engine#40954) 2023-04-05 [email protected] Copy canvaskit files directly into `flutter_web_sdk` (flutter/engine#40951) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: flutter/flutter#124277
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.