This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Remove redundant TargetPlatformNeedsSL. #40857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TargetPlatformNeedsSL was true for all target platforms. I believe we reworked this after we started embedding metadata in IPLR files perhaps? In any case, this seemed unused and was making the code harder to read. Just a cleanup that I didn't want to include in the compiler rework for SPIRV.
jonahwilliams
approved these changes
Apr 1, 2023
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
I believe we only use the iplr format in the flutter tool for user authored shaders, so if nothing is failing in CI this should be fine
zanderso
approved these changes
Apr 1, 2023
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TargetPlatformNeedsSL was true for all target platforms.
I believe we reworked this after we started embedding metadata in IPLR files perhaps? In any case, this seemed unused and was making the code harder to read. Just a cleanup that I didn't want to include in the compiler rework for SPIRV.