Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@chinmaygarde chinmaygarde changed the title Un-ifdef vulkan code in impellerc [Impeller] Un-ifdef vulkan code in impellerc Mar 30, 2023
@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023
@auto-submit auto-submit bot merged commit 2b6b9a0 into flutter:main Mar 30, 2023
@zanderso zanderso deleted the impellerc-vulkan-fix branch March 30, 2023 21:29
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 30, 2023
@dnfield
Copy link
Contributor

dnfield commented Mar 30, 2023

This also fixed Android builds.

@chinmaygarde
Copy link
Member

chinmaygarde commented Mar 31, 2023

Right. This was the cause of flutter/flutter#123742.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

[Impeller] Investigate why malioc diff produces different results for Vulkan shaders on macOS vs Linux hosts

3 participants