This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Complete the update semantics embedder API migration #40773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
changed the title
8 tasks
loic-sharma
force-pushed
the
clean_update_semantics
branch
2 times, most recently
from
119c05b to
65d572d
Compare
The old "update semantics" embedder API was deprecated as it could not guarantee ABI stability (see flutter/flutter#121176). It was replaced by a new embedder API (flutter#39807) and all affected embedders were migrated to this new embedder API (flutter#40072, flutter#40584). This change: 1. Removes plumbing that was used for the old "update semantics" embedder API 2. Moves all remaining tests to the types used by the new "update semantics" embedder API Completes: flutter/flutter#121176
loic-sharma
force-pushed
the
clean_update_semantics
branch
from
65d572d to
81a0d9c
Compare
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old "update semantics" embedder API was deprecated as it could not guarantee ABI stability (see flutter/flutter#121176). It was replaced by a new embedder API (#39807) and all affected embedders were migrated to this new embedder API (#40072, #40584).
This change:
Completes: flutter/flutter#121176
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.