This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "[web] Accepts assetBase through JS config. (#40615)" #40677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6cc2f9b, PR flutter#40670.
This solves an issue with the `library_annotations` lint that was
added to the repo:
```
info - test/engine/assets_test.dart:5:1 - This annotation must
be attached to a library directive. Try attaching library
annotations to library directives. - library_annotations
```
flutter-dashboard
bot
added
the
platform-web
mdebbar
approved these changes
Mar 28, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relands #40615, by:
library_annotationslint that was added to the repo:Fixes: flutter/flutter#122987
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.