This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Define which SemanticsNodes are a11y focusable on Android #4067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A node is considered focusable if it contains information that is interesing to the user. A node that doesn't add any semantic information of its own should not be focusable. It's expected that such a node has children, who have smeantics information and are therefore focusable. Fixes flutter/flutter#11179
goderbauer
changed the title
Contributor
|
|
Hixie
added a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2017
This roll includes: flutter/engine#4069 - Return generated kernel filename on incremental compilation results flutter/engine#4070 - Updates for the dart:fidl.internal rename and split flutter/engine#4072 - Set the is_official_build flag that disables GR_TEST_UTILS in Skia flutter/engine#4067 - Define which SemanticsNodes are a11y focusable on Android
goderbauer
added a commit
that referenced
this pull request
Sep 7, 2017
This reverts commit ccf68cd.
Hixie
added a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2017
This roll includes: flutter/engine#4069 - Return generated kernel filename on incremental compilation results flutter/engine#4070 - Updates for the dart:fidl.internal rename and split flutter/engine#4072 - Set the is_official_build flag that disables GR_TEST_UTILS in Skia flutter/engine#4067 - Define which SemanticsNodes are a11y focusable on Android
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A node is considered a11y focusable if it contains information that are interesting to the user. A node that doesn't add any semantic information of its own should not be focusable. It's expected that such a node has children, who have semantics information and are therefore focusable.
See also
MergeSemanticsto merge the child semantics of a node into the parent.Fixes flutter/flutter#11179.