Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@joshualitt
Copy link
Contributor

First patch is reland

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 24, 2023
@joshualitt joshualitt marked this pull request as ready for review March 25, 2023 01:41
@joshualitt
Copy link
Contributor Author

joshualitt commented Mar 25, 2023

@eyebrowsoffire ptal. The bug was in transform(see second commit). I audited the other methods and didn't see any other obvious mistakes like this, but then again most of the other functions with many arguments have a mixture of types so this sort of error would be less likely.

The changes to module and exports didn't seem to show up anywhere, but I'm reasonably sure we need them.

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants