This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Migrate canvaskit_api to JS types. #40538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
Contributor
Author
|
@eyebrowsoffire ptal, @ditman @mdebbar for FYI. Please feel free to add yourself as a reviewer if you like. |
Member
|
RSLGTM! I like the ability to remove casts! |
eyebrowsoffire
approved these changes
Mar 22, 2023
Contributor
eyebrowsoffire
left a comment
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Looks great! One small nit
joshualitt
force-pushed
the
3-js-types
branch
2 times, most recently
from
4db87a5 to
54695e7
Compare
joshualitt
added a commit
that referenced
this pull request
Mar 24, 2023
This reverts commit 7732ded.
zanderso
pushed a commit
that referenced
this pull request
Mar 24, 2023
joshualitt
added a commit
that referenced
this pull request
Mar 24, 2023
This reverts commit 7732ded.
eyebrowsoffire
pushed a commit
to eyebrowsoffire/engine
that referenced
this pull request
Mar 27, 2023
eyebrowsoffire
pushed a commit
to eyebrowsoffire/engine
that referenced
this pull request
Mar 27, 2023
…tter#40602) This reverts commit 7732ded.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.