This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Remove MipFilter::kNone redux #40491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 20, 2023 12:38
…r_descriptor_default_to_nearest_mip
…thub.com:jonahwilliams/engine into change_sampler_descriptor_default_to_nearest_mip
chinmaygarde
approved these changes
Mar 21, 2023
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
lgtm but I am not sure why the last one was reverted.
Contributor
Author
|
Compile error caused by dueling commits |
jonahwilliams
added
the
autosubmit
jonahwilliams
deleted the
change_sampler_descriptor_default_to_nearest_mip
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 21, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
May 15, 2024
Closes flutter/flutter#147259. Changes: - Make sure the default of `kNearest` is used consistently - Partial revert of #40491, re-adding `kBase` - Added some documentation about relevant enums, and why the default is `kNearest` - Wired up `kBase` in the Metal, Vulkan, and OpenGLES backends Expecting an update to the `dart_ui_filter_quality_none` golden file: >  For breadcrumbs around the mapping, see flutter/flutter#148253.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #40460