This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Ignore some MTLCompiler failures in impeller unit tests #40391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
force-pushed
the
ignore-mtlcompiler-failure
branch
from
9bc32f7 to
b849a5c
Compare
zanderso
force-pushed
the
ignore-mtlcompiler-failure
branch
from
b849a5c to
5d17962
Compare
jason-simmons
approved these changes
Mar 17, 2023
Member
Author
|
One of the presubmit checks caught an instance of this and the new code in |
gaaclarke
approved these changes
Mar 17, 2023
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
A couple nits about variable naming to make working with dynamic typing a bit easier and a note about logging allowed failures. Otherwise, lgtm.
| 'Command "%s" exited with code %d.' % | ||
| (command_string, process.returncode) | ||
| ) | ||
| allowed_failure = False |
Member
There was a problem hiding this comment.
Suggested change
| allowed_failure = False | |
| is_allowed_failure = False |
| allowed_string in stderr): | ||
| allowed_failure = True | ||
|
|
||
| if not allowed_failure: |
Member
There was a problem hiding this comment.
We should probably log allowed failures, right?
| forbidden_output=None, | ||
| expect_failure=False, | ||
| env=None, | ||
| allowed_failure_output=None, |
Member
There was a problem hiding this comment.
Suggested change
| allowed_failure_output=None, | |
| failure_allow_list=None, |
| start_time = time.time() | ||
| stdout_pipe = sys.stdout if not forbidden_output else subprocess.PIPE | ||
| stderr_pipe = sys.stderr if not forbidden_output else subprocess.PIPE | ||
| collect_output = forbidden_output or allowed_failure_output |
Member
There was a problem hiding this comment.
Suggested change
| collect_output = forbidden_output or allowed_failure_output | |
| should_collect_output = forbidden_output or allowed_failure_output |
Member
|
Doh. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 18, 2023
…122942) * e6334f166 [web] Remove image codecs from Canvaskit Chromium (flutter/engine#40309) * 56727d62c Revert "[Impeller] mark decoded images as optimized for GPU access (#40356)" (flutter/engine#40387) * 2cd19e3d1 Wrap the iOS platform message handler in an autorelease pool block (flutter/engine#40373) * bab7853ad Update analyzer for api_conform_test (flutter/engine#40386) * 87b2e82d1 Roll Fuchsia Mac SDK from z32cF6YFs6CvZbY3g... to 4ZrEK2uzGdp_Gz3DU... (flutter/engine#40385) * fc57995fe Ignore some MTLCompiler failures in impeller unit tests (flutter/engine#40391) * 2398c5222 Add doc comment to Pipeline (flutter/engine#40388) * f585d4bc5 [macOS] Remove a single accessibility root assumption (flutter/engine#40316) * 940cf3c98 remove temporary flag and make FlutterTest the default font for real (flutter/engine#40352) * a1bf9fd2a drawTextBlob should not be compatible with opacity inheritance (flutter/engine#40396) * 55bf0d85e Use bundled analyzer everywhere (flutter/engine#40398) * 8e580414a Roll Skia from 9bfb45d3e065 to 49b902e5fb91 (11 revisions) (flutter/engine#40397) * 77c53d25e Default the CanvasKit base URL to local artifacts. (flutter/engine#40293) * 625ea5395 Roll Skia from 49b902e5fb91 to aa983f5486f0 (7 revisions) (flutter/engine#40404) * 867679fac [Impeller] Add playground flag to render for a specific amount of time. (flutter/engine#40377) * d74169608 [Impeller] Remove unused bounds method from typographer interface (flutter/engine#40406) * 941323d77 Provisional iOS impeller flag flip (flutter/engine#40405) * bb971ab55 Revert "Default the CanvasKit base URL to local artifacts. (#40293)" (flutter/engine#40415)
zanderso
pushed a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also re-enables the tests.
Related flutter/flutter#117122