Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Fixed the conical gradient. #40371

Merged
auto-submit merged 1 commit into from
Mar 17, 2023
Merged

[Impeller] Fixed the conical gradient. #40371

auto-submit merged 1 commit into from
Mar 17, 2023

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Mar 17, 2023

I accidentally broke this while editing the pr in review. The test for it is coming in the golden image work I'm doing in #40366

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jonahwilliams
jonahwilliams approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2023
@auto-submit auto-submit bot merged commit 3a5c0e9 into flutter:main Mar 17, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
3a5c0e981 Fixed the conical gradient. (flutter/engine#40371)
3caae28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
3a5c0e981 Fixed the conical gradient. (flutter/engine#40371)
9173c41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
3a5c0e981 Fixed the conical gradient. (flutter/engine#40371)
62e2703
@chinmaygarde chinmaygarde changed the title Fixed the conical gradient. [Impeller] Fixed the conical gradient. Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gaaclarke gaaclarke

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaaclarke @jonahwilliams