Output web test artifacts to out directory. #40355
Conversation
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| io.Directory get webUiBuildDir => io.Directory(pathlib.join( | ||
| webUiRootDir.path, | ||
| 'build', | ||
| outDir.path, |
There was a problem hiding this comment.
Can we copy to both locations as a transitional step to not break the current tests?
There was a problem hiding this comment.
I don't think we'll have to do that. AFAIK the current tests will not be broken by this.
| List<io.File> _flatListSourceFiles(io.Directory directory) { | ||
| // This is the old path that tests used to be built into. Ignore anything | ||
| // within this path. | ||
| final String legacyBuildPath = path.join(environment.webUiRootDir.path, 'build'); |
There was a problem hiding this comment.
Should we also add the legacy path to the felt clean command?
engine/lib/web_ui/dev/clean.dart
Lines 40 to 49 in b2720b7
I personally rarely use felt clean so I don't have a strong opinion here.
There was a problem hiding this comment.
Yeah good idea
|
test-exempt: is tests |
eyebrowsoffire
added
the
autosubmit
4 participants
No description provided.