Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@CaseyHillers
Copy link
Contributor

Reverts #40031

Blocking the engine->flutter roller.

ELAPSED TIME: 17.089s for bin/flutter analyze --flutter-repo --watch --benchmark in .
▌18:58:12▐ Snippet code...
RUNNING: cd .; bin/cache/dart-sdk/bin/dart --enable-asserts /b/s/w/ir/x/w/Á flutter sdk/dev/bots/analyze_snippet_code.dart --verbose
bin/cache/pkg/sky_engine/lib/ui/painting.dart:1628:11: A value of type 'dynamic' can't be assigned to a variable of type 'ByteData' (top-level declaration) (invalid_assignment)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:1628:12: The await expression can only be used in an async function (top-level declaration) (await_in_wrong_context)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:1628:18: Method invocation or property access on a 'dynamic' target (top-level declaration) (avoid_dynamic_calls)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:1628:18: Undefined name 'image' (top-level declaration) (undefined_identifier)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:1628:43: Method invocation or property access on a 'dynamic' target (top-level declaration) (avoid_dynamic_calls)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:1628:43: Undefined name 'ImageByteFormat' (top-level declaration) (undefined_identifier)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:1630:7: The function 'print' should have a return type but doesn't (top-level declaration) (always_declare_return_types)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:1630:13: Expected an identifier (top-level declaration) (missing_identifier)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:1630:16: Expected to find ')' (top-level declaration) (expected_token)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:1630:16: Missing type annotation (top-level declaration) (always_specify_types)
bin/cache/pkg/sky_engine/lib/ui/painting.dart:1630:75: A function body must be provided (top-level declaration) (missing_function_body)
Found 11 snippet code errors.

@CaseyHillers CaseyHillers requested a review from gaaclarke March 15, 2023 03:08
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 15, 2023
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 15, 2023
@auto-submit auto-submit bot merged commit d9770af into main Mar 15, 2023
@auto-submit auto-submit bot deleted the revert-40031-wide-gamut-ui-image branch March 15, 2023 04:04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants