Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@kjlubick
Copy link
Contributor

https://skia-review.git.corp.google.com/c/skia/+/656237 changed how some GPU files are #included Skia-side, which revealed some missing forward declares and #includes in Flutter.

These are not the minimal set of changes needed to fix the current issue; some of them were found via git grep and are trying to proactively address issues that will arise as Skia continues to re-organize its codebase.

Pre-launch Checklist

  • [ x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ x ] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [ x ] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • [ x ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • [ x ] I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@CaseyHillers CaseyHillers requested a review from zanderso March 14, 2023 20:00
@CaseyHillers
Copy link
Contributor

@zanderso can you take a look at this? This is going to block Google testing

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 14, 2023

auto label is removed for flutter/engine, pr: 40279, due to This PR has not met approval requirements for merging. You have project association CONTRIBUTOR and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 14, 2023

auto label is removed for flutter/engine, pr: 40279, due to Validations Fail.

@CaseyHillers
Copy link
Contributor

\cc @jiahaog

@kjlubick kjlubick deleted the forward-declare branch April 10, 2023 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants