This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Make matrix image filter in saving layer work as expected #40171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Mar 13, 2023
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Thank you so much! Minor nits but lgtm otherwise.
bdero
approved these changes
Mar 13, 2023
| input_snapshot->texture->GetYCoordScale(); | ||
|
|
||
| auto transform = entity.GetTransformation() * effect_transform; | ||
| auto transform = entity.GetTransformation() * effect_transform.Basis(); |
Member
There was a problem hiding this comment.
The given effect transform should already have its translation/projective coords stripped. Can we remove the Basis() calls here and in the gaussian blur?
Member
Author
There was a problem hiding this comment.
The given effect transform should already have its translation/projective coords stripped. Can we remove the
Basis()calls here and in the gaussian blur?
I modified the implementation of FilterContents::SetEffectTransform, because MatrixImageFilter needs an original matrix instead of a stripped one, otherwise the result will be incorrect (such as when nesting Transformed widget). So I added Basis() to blur and morphology.
void FilterContents::SetEffectTransform(Matrix effect_transform) {
- effect_transform_ = effect_transform.Basis();
+ effect_transform_ = effect_transform;
}
ColdPaleLight
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix flutter/flutter#121893
fix flutter/flutter#120879
This PR tries to distinguish whether it is a subpass scene (aka. save layer) in MatrixImageFilterContents, and do different processing for subpass scenes.
without patch
with patch
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.