Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@bdero
Copy link
Member

@bdero bdero commented Mar 9, 2023

Quick fix for --enable-impeller-3d

We may just remove it eventually but I've been keeping it working just in case.

@bdero bdero requested review from chinmaygarde and flar March 9, 2023 02:06
@bdero bdero self-assigned this Mar 9, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flar
Copy link
Contributor

flar commented Mar 9, 2023

The change was reverted. I had noticed this and fixed it in the follow-on PR, but that PR can't go in now that we've taken 2 steps back.

I'll get this one right when I reland the PR that caused it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants