Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Compile tests as generator. #40106

Merged
auto-submit merged 2 commits into from
Mar 17, 2023
Merged

Compile tests as generator. #40106

auto-submit merged 2 commits into from
Mar 17, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 7, 2023

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chinmaygarde
Copy link
Member

chinmaygarde commented Mar 9, 2023

Looks like the failure is related.

@godofredoc
Copy link
Contributor Author

godofredoc commented Mar 16, 2023

Looks like the failure is related.
It required flutter/flutter@be97d03

eyebrowsoffire
eyebrowsoffire suggested changes Mar 17, 2023
View reviewed changes
eyebrowsoffire
eyebrowsoffire approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2023
@auto-submit auto-submit bot merged commit c023298 into flutter:main Mar 17, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 17, 2023
@engine-flutter-autoroll
c0232985b Compile tests as generator. (flutter/engine#40106)
546fa13
@godofredoc godofredoc deleted the compile_separately branch March 17, 2023 20:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @chinmaygarde @eyebrowsoffire