This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add web_engine build configuration. #40044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyebrowsoffire
approved these changes
Mar 3, 2023
Contributor
eyebrowsoffire
left a comment
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Looks great! Just a couple suggestions.
| ], | ||
| "scripts": [ | ||
| "third_party/dart/tools/sdks/dart-sdk/bin/dart", | ||
| "flutter/lib/web_ui/dev/felt.dart" |
Contributor
There was a problem hiding this comment.
For all these invocations of felt, it would be better to run the shell script that bootstraps felt itself, which is just flutter/lib/web_ui/dev/felt. The shell script will find and use the proper prebuilt dart sdk on its own.
ci/builders/web_engine.json
Outdated
| ] | ||
| "builds": [ | ||
| { | ||
| "archives": [], |
Contributor
There was a problem hiding this comment.
You could also consider archiving here, and removing the web sdk build and archival from the linux_host_engine v2 builder
godofredoc
added
the
autosubmit
Contributor
|
Also, should we actually add a builder to .ci.yaml for the web_engine using the v2 recipes? |
godofredoc
added a commit
that referenced
this pull request
Mar 3, 2023
This reverts commit b0edd18.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial configuration for web engine builds using engine_v2 recipes. The implementation will be executed in multiple steps to allow to land fixes to recipes and web engine tooling along the way.
These are the expected steps:
This PR covers i).
Bug: flutter/flutter#119036
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.