Fix includes of SkBitmap/SkImage #40026
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jason-simmons
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 40026, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
|
auto label is removed for flutter/engine, pr: 40026, due to Validations Fail. |
Client CLs: - https://crrev.com/c/4303437 - flutter/engine#40026 Change-Id: Idcc4419e783130697ffcb6e9dff3b0f4ea2a08d0 Bug: skia:13983, skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/651420 Reviewed-by: Brian Osman <[email protected]> Commit-Queue: Kevin Lubick <[email protected]>
2 participants
In https://skia-review.googlesource.com/c/skia/+/651420 we are cleaning up #includes in our public headers.
This PR fixes the missing includes in Flutter that were a result of transitive #includes.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.