This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Remove another accessibility root ID assumption #39994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
changed the title
loic-sharma
force-pushed
the
windows_a11y_root
branch
from
317aa87 to
4f09110
Compare
loic-sharma
requested review from
cbracken,
chunhtai,
dkwingsmt and
yaakovschectman
| bridge->CommitUpdates(); | ||
|
|
||
| // Look up the root windows node delegate. | ||
| auto node_delegate = bridge->GetFlutterPlatformNodeDelegateFromID(1).lock(); |
Contributor
There was a problem hiding this comment.
Should we also test that GetFlutterPlatformNodeDelegateFromID(0) returns node0 as we would expect? If the rest of the test passes, I'd think it would, but it may still be useful to make sure arbitrary ID ordering works.
Member
Author
There was a problem hiding this comment.
Good idea. I also made the root ID 1 and the child ID 2 and updated the tests to:
- Verify node ID
0is unused - Verify node ID
1and2exist as expected
loic-sharma
force-pushed
the
windows_a11y_root
branch
from
4f09110 to
d85c867
Compare
cbracken
approved these changes
Mar 3, 2023
yaakovschectman
approved these changes
Mar 3, 2023
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the root accessibility semantics node is guaranteed to have ID 0. In a multi-window world, each view will have its own semantics tree, but semantic node IDs will be globally unique. In other words, the semantics tree's root will no longer be guaranteed to have ID 0.
This change removes another "root ID is 0" assumption from the Windows embedder that was missed in #39441:
0when getting the native rootIAccessibleobjectIAccessibleobject fromFlutterWindowsViewtoAccessibilityBridgeWindowsPart of flutter/flutter#119391
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.