Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jonahwilliams
Copy link
Contributor

I can verify this with an integration test, but is that fact that we created mipmaps observable through the impeller API so I can write a simpler unittest?

Fixes flutter/flutter#121015

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@chinmaygarde
Copy link
Member

I was going to suggest that the blit pass do nothing in case the mip count is not greater than 1. What that would be good to add anyway, we should also encourage folks to not create the pass in the first place.

@jonahwilliams jonahwilliams added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Feb 28, 2023
@auto-submit auto-submit bot merged commit 55a96c2 into flutter:main Feb 28, 2023
@jonahwilliams jonahwilliams deleted the fix_mips_when_1 branch February 28, 2023 19:50
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller needs tests

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

[Impeller] Generate Mipmaps For Texture Validation failed.

2 participants