Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix pylint errors #39934

Merged
bdero merged 1 commit into from
Feb 28, 2023
Merged

Fix pylint errors #39934

bdero merged 1 commit into from
Feb 28, 2023

Conversation

@bdero
Copy link
Member

@bdero bdero commented Feb 28, 2023

Greens the tree.

@bdero bdero self-assigned this Feb 28, 2023
jonahwilliams
jonahwilliams approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XilaiZhang
Copy link
Contributor

XilaiZhang commented Feb 28, 2023

thanks for the fix! Umm i did run yapf -i on the file this time, umm is there some formatting beyond yapf?

@bdero
Copy link
Member Author

bdero commented Feb 28, 2023 •
edited
Loading

I will force land this to green the tree once Linux Android clang-tidy passes (pylint is indeed running for this file in presubmits now; it's failing in #39933).

@zanderso
Copy link
Member

zanderso commented Feb 28, 2023

You need to run both the lint and format scripts the same way that CI runs them.

@bdero bdero merged commit 368ecaa into flutter:main Feb 28, 2023
@XilaiZhang
Copy link
Contributor

XilaiZhang commented Feb 28, 2023

Thanks for explaining!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 28, 2023
@engine-flutter-autoroll
368ecaaf6 Fix pylint error (flutter/engine#39934)
958b9e4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 28, 2023
@engine-flutter-autoroll
368ecaaf6 Fix pylint error (flutter/engine#39934)
1e79646
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@zanderso zanderso Awaiting requested review from zanderso

2 more reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bdero bdero

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bdero @XilaiZhang @zanderso @jonahwilliams