This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Actually print out if xcrun metal fails #39926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous commit was exiting with an unhelpful error that did not contain the failure output. This prints the failure output more nicely.
dnfield
added
e: impeller
autosubmit
zanderso
approved these changes
Feb 27, 2023
|
|
||
| subprocess.check_output(command, stderr=subprocess.STDOUT) | ||
| try: | ||
| subprocess.check_output(command, stderr=subprocess.STDOUT, text=True) |
Member
There was a problem hiding this comment.
The presubmits will tell, but hopefully CI has a recent enough python for text=True.
Contributor
Author
There was a problem hiding this comment.
I'm pretty sure we do. I was going to use subprocess.run here but I'm not sure we have a recent enough for that. If it fails I'll change this.
Contributor
Author
There was a problem hiding this comment.
impeller/tools/build_metal_library.py:116:2: C0103: Variable name "e" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
For real?
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 39926, due to - The status or check suite Linux Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dnfield
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 39926, due to - The status or check suite Mac iOS clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous commit was exiting with an unhelpful error that did not contain the failure output. This prints the failure output more nicely.