This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove surface check when querying ExternalViewEmbedder #39803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dkwingsmt
force-pushed
the
remove-surface-for-exviem
branch
from
0f3c943 to
a9b0de1
Compare
dkwingsmt
requested review from
chinmaygarde,
dnfield,
iskakaushik and
jonahwilliams
chinmaygarde
approved these changes
Feb 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 24, 2023
QuncCccccc
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 24, 2023
…ions) (#121383) * 6a7ea36c8 Remove surface check when querying ExternalViewEmbedder (flutter/engine#39803) * 8496df610 Fix referenes in docs (flutter/engine#39828) * 2f4b81be1 Roll Skia from fff6c987d803 to c23446d2da26 (10 revisions) (flutter/engine#39831) * 167c97bc3 Revert "Match PlatformConfiguration properties to PlatformDispatcher ones (#39685)" (flutter/engine#39833)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a check for
surface_when queryingExternalViewEmbedder.This logic is apparently not needed, and dated back in the day when
ExternalViewEmbedderwas child of theSurface. Later it was separated out, but this logic was kept (see #22470 by @iskakaushik; the first version of that PR removed this logic, but the second version kept it, likely by accident according to my talk with him).It's part of the project to adapt the painting module to multi-view. In the future,
Rasterizerwill contain multipleSurfaces instead of just one, so the references tosurface_need to be removed. Some of them will be delegated to other classes, some be multiplied along withsurface_, but this one is special in that it doesn't make sense. I'm removing it in a separate PR to try roll it in, just in case it breaks anything.This PR shouldn't need unit tests.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.