This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Remove CFv1 support #39732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note for myself: going to also look at deleting component_v1.h and cc. |
anp
force-pushed
the
rm-runner-cmx
branch
4 times, most recently
from
7401668 to
e4624d3
Compare
anp
changed the title
There are no longer any CMX-based components outside of prebuilts which are run by existing flutter runner prebuilts.
arbreng
approved these changes
Mar 1, 2023
arbreng
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2023
chinmaygarde
pushed a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Mar 3, 2023
There are no longer any CMX-based components outside of prebuilts which are run by existing flutter runner prebuilts.
anp
added a commit
to anp/engine
that referenced
this pull request
Mar 7, 2023
…)" This reverts commit 24e69c8.
tarobins
pushed a commit
that referenced
this pull request
Mar 7, 2023
anp
added a commit
to anp/engine
that referenced
this pull request
Mar 9, 2023
…)" Previously reverted in flutter#40104, this should now be safe to reland as the last dependency has been deleted internally. This reverts commit 3019109.
arbreng
pushed a commit
that referenced
this pull request
Mar 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support from the Fuchsia embedding for Component Framework v1 (CMX files) which is being turned down.
To my knowledge, all existing builds using CMX-based Flutter components are using prebuilts with a Flutter engine from early December 2022 and will not be affected by this change.
Pre-launch Checklist
///).