This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove obsolete references in ViewConfiguration documentation #39708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroux
force-pushed
the
fix_doc_obsolete_references_to_screen_configuration
branch
from
2ac2eed to
855ac0c
Compare
Contributor
Author
|
Hey @gspencergoog! Is reusing comments from FlutterView the right fix? |
bleroux
force-pushed
the
fix_doc_obsolete_references_to_screen_configuration
branch
from
855ac0c to
4a76031
Compare
Member
|
Ping @gspencergoog @goderbauer |
goderbauer
added
the
autosubmit
bleroux
deleted the
fix_doc_obsolete_references_to_screen_configuration
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 23, 2023
…121365) * 2bc07cac7 Roll Skia from a321a8750271 to 1b2d815e9778 (5 revisions) (flutter/engine#39821) * 57cbf0858 Roll Skia from 1b2d815e9778 to fff6c987d803 (2 revisions) (flutter/engine#39823) * 2d2b51d69 Remove obsolete references in ViewConfiguration documentation (flutter/engine#39708) * cad5eec1b Match PlatformConfiguration properties to PlatformDispatcher ones (flutter/engine#39685)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces obsolete comments, referencing the non-existing
ScreenConfigurationtype, inViewConfigurationand replaces them with copied/pasted comments from windows.dart.Related Issue
Fixes flutter/flutter#120961
Tests
Documentation only.