This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Assert checks for NaN/infinite values in Skia canvas Dart wrappers #3967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Hixie
reviewed
Aug 8, 2017
lib/ui/painting.dart
Outdated
| // Painting APIs will also warn about arguments representing NaN or infinite | ||
| // coordinates, which can not be rendered by Skia. | ||
|
|
||
| bool rectIsValid(Rect rect) { |
Contributor
There was a problem hiding this comment.
These should probably be private (prefixed with _ so they're only visible in this file).
Contributor
|
|
jason-simmons
force-pushed
the
canvas_nan_check
branch
from
c80381b to
9c774f9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.