Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Enable the same tests in linux host for v2 and legacy recipes. #39635

Merged
auto-submit merged 12 commits into from
Feb 16, 2023
Merged

Enable the same tests in linux host for v2 and legacy recipes. #39635

auto-submit merged 12 commits into from
Feb 16, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Feb 14, 2023

Dart tests were not being run in the engine v2 linux builds.

Bug: flutter/flutter#120701

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc changed the title Enable the same test in linux host for v2 and legacy recipes. Enable the same tests in linux host for v2 and legacy recipes. Feb 15, 2023
@godofredoc godofredoc requested a review from zanderso February 15, 2023 03:48
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 16, 2023
@auto-submit auto-submit bot merged commit 3be7ed4 into flutter:main Feb 16, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2023
@engine-flutter-autoroll
3be7ed4c2 Enable the same tests in linux host for v2 and legacy recip…
bb02cd7 
…es. (flutter/engine#39635)
godofredoc pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 2be7253c9b10 to e4cb80e22ee1 (2 revisions) (#…
df13ea2 
…120903)

* 3be7ed4c2 Enable the same tests in linux host for v2 and legacy recipes. (flutter/engine#39635)

* e4cb80e22 Roll Skia from f2c67bb88bc6 to 10c9e3b2185f (2 revisions) (flutter/engine#39680)
@godofredoc godofredoc mentioned this pull request Mar 3, 2023
Closed
@godofredoc godofredoc deleted the add_tests branch March 8, 2023 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @zanderso