This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove usage of NaN values in canvas_test that caused a Skia assert failure #3962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
Was the assertion failure in debug only? |
chinmaygarde
approved these changes
Aug 8, 2017
Member
Author
|
yes - the buildbots run the engine Dart tests using a flutter_tester built in host_debug_unopt mode with assertions turned on |
Member
|
As long as the engine does not crash on the mobile shells. |
Contributor
|
Can we instead fix tonic to fail when trying to convert a NaN? This code is trying to make sure we don't crash when we pass a NaN, so removing the NaN isn't really a long-term fix. :-) |
Member
Author
|
Skia's SkRect can represent NaN coordinates, but the API doesn't support drawing an object with NaN coordinates. The engine's Canvas Dart wrappers could check whether a rect is finite before passing it onward to Skia. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.